Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-network): annotated pod in creation loop #2456

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7640

What this PR does / why we need it:

longhorn/longhorn#7640 (comment)

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Jan 12, 2024
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-storage-network-caused-im-pod-creation-loop branch from 7f8dca4 to 9c48ee0 Compare January 12, 2024 06:36
@c3y1huang c3y1huang marked this pull request as ready for review January 12, 2024 06:48
@c3y1huang c3y1huang requested a review from a team as a code owner January 12, 2024 06:48
@c3y1huang
Copy link
Contributor Author

c3y1huang commented Jan 12, 2024

CodeFactor is failing. I don't know why it's checking codes outside of this PR. cc @innobead

longhorn-7640

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-storage-network-caused-im-pod-creation-loop branch from 9c48ee0 to 9ae8c3a Compare January 12, 2024 07:00
@innobead
Copy link
Member

CodeFactor is failing. I don't know why it's checking codes outside of this PR. cc @innobead

That's OK, but need to see why it verified the non-changed part.

@mantissahz please review this as well.

@innobead innobead self-requested a review January 12, 2024 14:37
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead innobead merged commit 43e997c into longhorn:master Jan 12, 2024
4 of 5 checks passed
@innobead
Copy link
Member

@mergify backport v1.6.x

That is a prompt fix @c3y1huang well done.

Copy link

mergify bot commented Jan 12, 2024

backport v1.6.x

✅ Backports have been created

@c3y1huang c3y1huang deleted the fix-storage-network-caused-im-pod-creation-loop branch January 15, 2024 00:29
@ejweber
Copy link
Contributor

ejweber commented Apr 4, 2024

@mergify backport v1.5.x v1.4.x

Copy link

mergify bot commented Apr 4, 2024

backport v1.5.x v1.4.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants